Remove unnecessary memoization from a code example #4803
Merged
+2
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: 📝 Documentation Fix
about: Removing unnecessary memoization from a code example as it might confuse people
What docs page needs to be fixed?
What is the problem?
Using (
createSelector) for theselectA1selector directly contradicts the Balance Selector Usage section, which says in bold text the following: A selector function that does a direct lookup and return of a value should be a plain function, not memoized. Therefore this code example might confuse people about when to use memoization.What changes does this PR make to fix the problem?
Not using
createSelectorfor this one.